Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes bc_desktop behavior #254

Merged
merged 7 commits into from
May 21, 2024
Merged

Fixes bc_desktop behavior #254

merged 7 commits into from
May 21, 2024

Conversation

HazelGrant
Copy link
Contributor

@HazelGrant HazelGrant commented May 16, 2024 •
edited
Loading

Based on the idea that any node type + 1 gpu should not override number of gpus on form submission.

@HazelGrant HazelGrant marked this pull request as ready for review May 16, 2024 15:12
@HazelGrant HazelGrant requested a review from johrstrom May 16, 2024 15:12
@johrstrom
Copy link
Contributor

If I try a pitzer desktop with 1 gpus and any node type I get the error undefined method +' for nil:NilClass`.

johrstrom
johrstrom approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only tried pitzer/1 gpu/any node and it worked. When it lands we can test all the variations.

@HazelGrant HazelGrant merged commit 1264b44 into master May 21, 2024
1 check passed
@HazelGrant HazelGrant deleted the gpu-bug-fixes branch May 21, 2024 15:57
@johrstrom johrstrom mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johrstrom johrstrom johrstrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HazelGrant @johrstrom